Skip to content

fix(agent): include GlobalTimeout during allocate phase#928

Open
rene-oromtz wants to merge 6 commits intomainfrom
feat/add-multi-allocate
Open

fix(agent): include GlobalTimeout during allocate phase#928
rene-oromtz wants to merge 6 commits intomainfrom
feat/add-multi-allocate

Conversation

@rene-oromtz
Copy link
Contributor

@rene-oromtz rene-oromtz commented Feb 18, 2026

Description

This PR adds a a schema validation for allocate_data.

This PR adds GlobalTimeout to the allocate phase, without a proper parent job id, the agent can wait indefinitively in the allocate phase until job is manually cancelled. Ideally, the best approach is to enforce the schema in server side but for now, just adding this timeout should allow no agent exceeds the allowed amount of time.

The rationale on not including a schema on server side is that there seems to be cases where users that rely on Spread testing are using the allocate phase to fetch for the IP and then use that IP to run manual tests, this is not ideal as the reserve stage should serve for that purpose but we should at least give a proper warning before enforcing the restriction on server side.

Resolved issues

Resolves #799
Resolves CERTTF-713

Documentation

Web service API changes

Tests

Added couple of unit tests for testing agent exits on allocate status

@rene-oromtz rene-oromtz force-pushed the feat/add-multi-allocate branch from 16b0278 to 3614347 Compare February 18, 2026 20:44
@codecov
Copy link

codecov bot commented Feb 18, 2026

Codecov Report

❌ Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.07%. Comparing base (9cbb26f) to head (d104f1d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #928      +/-   ##
==========================================
+ Coverage   73.85%   74.07%   +0.21%     
==========================================
  Files         108      108              
  Lines       10313    10322       +9     
  Branches      886      888       +2     
==========================================
+ Hits         7617     7646      +29     
+ Misses       2508     2488      -20     
  Partials      188      188              
Flag Coverage Δ *Carryforward flag
agent 76.16% <90.90%> (+1.75%) ⬆️
cli 89.56% <ø> (ø) Carriedforward from 8a3e71c
device 59.86% <100.00%> (ø)
server 87.85% <ø> (ø) Carriedforward from 8a3e71c

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
Agent 76.16% <90.90%> (+1.75%) ⬆️
CLI 89.56% <ø> (ø)
Common ∅ <ø> (∅)
Device Connectors 59.86% <100.00%> (ø)
Server 87.85% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rene-oromtz rene-oromtz marked this pull request as draft February 18, 2026 21:00
@rene-oromtz rene-oromtz changed the title fix(server): add validation for allocate phase only for multi device agents. fix(agent): include GlobalTimeout during allocate phase Feb 19, 2026
@rene-oromtz rene-oromtz force-pushed the feat/add-multi-allocate branch from 878591e to 8a3e71c Compare February 24, 2026 22:33
@rene-oromtz rene-oromtz marked this pull request as ready for review February 24, 2026 22:42
@rene-oromtz rene-oromtz requested a review from ajzobro February 24, 2026 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Agents stuck when allocated

1 participant