fix(agent): include GlobalTimeout during allocate phase#928
Open
rene-oromtz wants to merge 6 commits intomainfrom
Open
fix(agent): include GlobalTimeout during allocate phase#928rene-oromtz wants to merge 6 commits intomainfrom
rene-oromtz wants to merge 6 commits intomainfrom
Conversation
16b0278 to
3614347
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #928 +/- ##
==========================================
+ Coverage 73.85% 74.07% +0.21%
==========================================
Files 108 108
Lines 10313 10322 +9
Branches 886 888 +2
==========================================
+ Hits 7617 7646 +29
+ Misses 2508 2488 -20
Partials 188 188
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
This reverts commit 3614347.
878591e to
8a3e71c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a a schema validation forallocate_data.This PR adds GlobalTimeout to the allocate phase, without a proper parent job id, the agent can wait indefinitively in the allocate phase until job is manually cancelled. Ideally, the best approach is to enforce the schema in server side but for now, just adding this timeout should allow no agent exceeds the allowed amount of time.
The rationale on not including a schema on server side is that there seems to be cases where users that rely on Spread testing are using the allocate phase to fetch for the IP and then use that IP to run manual tests, this is not ideal as the reserve stage should serve for that purpose but we should at least give a proper warning before enforcing the restriction on server side.
Resolved issues
Resolves #799
Resolves CERTTF-713
Documentation
Web service API changes
Tests
Added couple of unit tests for testing agent exits on allocate status