Open
Conversation
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in a week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some of the unit tests unfortunately require running something with the agent that does a sleep, in order to test timeouts, etc. This is also impacted by the 10s output polling delay, because if you sleep for <10s then the thing the agent runs will exit before it gets a chance to timeout. This allows adjusting that output polling delay through a config option, which you may want to do anyway if you don't like that default.
And no, this isn't something you can just get around with things like freezegun. It's relying on a long running subprocess kicked off by the agent.
It also improves the time it takes to run the unit tests that require sleeps.
Resolved issues
No real issue, just trying to speed things up a bit
Documentation
Added docs to the agent reference section for the new output_polling_interval option, and adjusted the one for "polling_interval" to make it clear that it was about polling the server for new jobs. Hopefully this makes the difference pretty clear.
Web service API changes
N/A
Tests
This allowed adjusting the unit tests, so that was the point :)