refactor: do not track transaction done status #191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to monitor the done status of Sqlair transactions. This is already done in the standard lib transaction implementation at a level where there is negligible perfomance benefit. Most importantly, a context cancellation automatically rolls back a transaction, which marks it done in the standard implementation, but of which Sqlair would be unaware.
SimonRichardson
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to monitor the done status of Sqlair transactions. This is already done in the standard lib transaction implementation at a level where there is negligible performance benefit to adding the tracking at a layer above.
More importantly, a context cancellation automatically rolls back a transaction, which marks it done in the standard implementation, but of which Sqlair would be unaware. In such a case the work to track the status is made redundant.
Here we simply remove the tracking. The modified test asserts that the behaviour is effectively unchanged.