CRDC-H Decimals vs YAML from https://github.com/cancerDHC/ccdhmodel/issues/131 #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaurav
reviewed
Dec 7, 2021
Collaborator
I agree: since this is specifically testing the Python data classes rather than something to do with data harmonization, I think it belongs in the ccdhmodel repo. Could you please create a PR for it over there? I have some other suggestions for you as well, but I think it'd make move it over first. Thanks! |
gaurav
requested changes
Dec 7, 2021
Collaborator
gaurav
left a comment
gaurav
left a comment
There was a problem hiding this comment.
Once you've created a PR for this test in the CRDCH repo, I think you can go ahead and close this PR here.
and the pointof the test is to illustrate that cm.Observation(observation_type=cm.CodeableConcept(), value_decimal=1.23) can't be serialized to YAML
don't you trust me to merge in from main to feature?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just an illustration of cancerDHC/ccdhmodel#131
I guess it should be moved into the same repo