Skip to content

fix: invalid tag, add requirements to readme, remove -w arg to base64 #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: invalid tag, add requirements to readme, remove -w arg to base64 #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Fluentd image to send Kubernetes logs to CloudWatch


## Requirements

* envsubst: this is part of `gettext` package. If you're on macOS and using `brew`, you will have to force link `brew link --force gettext`

## Deployment

1. Create AWS IAM user which has permission to store logs to CloudWatch
Expand Down Expand Up @@ -28,7 +33,7 @@ LOGGING_AWS_ACCESS_KEY_ID=<your key> LOGGING_AWS_SECRET_ACCESS_KEY=<your secret>

## Removal

1. If you set custom values for the namespace or resource name environment variables,
1. If you set custom values for the namespace or resource name environment variables,
ensure they are still set to your values (`NAMESPACE`,`APP_NAME`,`SECRET_NAME`,`CONFIG_NAME`)

2. Run `delete.sh`
Expand Down
6 changes: 3 additions & 3 deletions deploy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ set -e
: ${CONFIG_NAME:=$APP_NAME}
: ${ENV_NAME:=system}
: ${NAMESPACE:=kube-system}
: ${IMAGE_NAME:=callstats/fluentd-kubernetes-cloudwatch:v1.1.2}
: ${IMAGE_NAME:=callstats/fluentd-kubernetes-cloudwatch:latest}
: ${CW_LOG_GROUP:=kubernetes-cluster}

#
Expand All @@ -38,8 +38,8 @@ metadata:
app: $APP_NAME
env: $ENV_NAME
data:
AWS_ACCESS_KEY_ID: $(echo -n "${LOGGING_AWS_ACCESS_KEY_ID}" | base64 -w 0)
AWS_SECRET_ACCESS_KEY: $(echo -n "${LOGGING_AWS_SECRET_ACCESS_KEY}" | base64 -w 0)
AWS_ACCESS_KEY_ID: $(echo -n "${LOGGING_AWS_ACCESS_KEY_ID}" | base64)
AWS_SECRET_ACCESS_KEY: $(echo -n "${LOGGING_AWS_SECRET_ACCESS_KEY}" | base64)
END

#
Expand Down