added cdnAuth configParams, other changes based on feedback #36
+8
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eljasala
reviewed
Feb 12, 2021
| additionalIDs: additionalIDs, // additionalIDs object, contains application related IDs. | ||
| collectLegacyStats: true //enables the collection of legacy stats in chrome browser | ||
| collectIP: true //enables the collection localIP address | ||
| cdnAuth: true //Uses the CDN based URL for contacting Authentication Servers. |
There was a problem hiding this comment.
Probably just "Use CDN for authentication"
There was a problem hiding this comment.
Uses the CDN for authentication instead of the authentication within the region associated with your organisation.
|
csioCdnAuth? Just to imply it's callstats.io related. We don't do it in other places -- so not sure. My main concern is if cdnAuth misleads people. |
|
@karthikbr82 Could also make the example fixes for status and messages on readme.callstats.io? |
vr000m
suggested changes
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.