You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Consolidate daemon-wire error conversion with the kernel error API. Daemon errors now have one canonical owner, while the existing contracts type surface remains compatible.
Validation
Not run locally at the requester’s direction; CI will validate this follow-up PR.
Exact head a0e20cf is not ready because it breaks the released contracts façade. The root package exports ./contracts through src/sdk/contracts.ts, and this patch removes that file's DaemonError re-export. Existing consumers of import type { DaemonError } from agent-device/contracts`` will stop typechecking, contrary to the compatibility claim. Keep the canonical owner and conversion in @agent-device/kernel/errors, but re-export `DaemonError` from `src/sdk/contracts.ts` and add a public-surface regression assertion. The internal consolidation and wire-field preservation otherwise look sound, and exact-head CI is green.
Addressed in aab0dfa: agent-device/contracts again re-exports DaemonError directly from the canonical @agent-device/kernel/errors module, while @agent-device/kernel/contracts no longer re-exports it. Added a public-facade type regression assertion.
Clean re-review at aab0dfa4. The released agent-device/contracts façade again exports DaemonError from its canonical kernel-errors owner, and the new public-facade type assertion pins that compatibility contract. Internal daemon-error rehydration still preserves the full wire shape, and the removed client helper has no remaining route. All completed exact-head checks are green; iOS Smoke is still in progress, so CI completion remains the merge condition.
Preview removed because the pull request was closed.
2026-07-30 11:35 UTC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ready-for-humanValid work that needs human implementation, judgment, or maintainer merge
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidate daemon-wire error conversion with the kernel error API. Daemon errors now have one canonical owner, while the existing contracts type surface remains compatible.
Validation
Not run locally at the requester’s direction; CI will validate this follow-up PR.