fix: prevent slider snapping back after seek#1493
Open
Mestane wants to merge 1 commit into
Open
Conversation
Collaborator
|
Is this still an issue in v2? |
Contributor
Author
In v2, the media slider appears to be drag-only clicking directly to a position doesn't seem to work, so the snap-back issue no longer occurs in practice. However, if click-to-seek is intended behavior in v2, this fix would need to be reworked since the current implementation is not compatible with v2's slider changes. |
Contributor
Author
Fixed in v2 the root cause was in |
Mestane
added a commit
to Mestane/shell
that referenced
this pull request
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When seeking via the progress slider, the slider briefly snaps back to the previous position before settling at the correct seek point. This is more pronounced on lower-end hardware where the MPRIS position update takes longer to come through.
Fix
Added an
isSeekingproperty to the slider and a 500ms cooldownTimer(consistent with the approach already used inLyricsService.qml). TheBindingis now suspended whileisSeekingis true, giving Quickshell enough time to receive and reflect the updated MPRIS position before the binding re-activates.fixed #1485