Skip to content

caddyfile: reset wildcard client auth for exact hosts#7867

Open
VatsalGoel3 wants to merge 3 commits into
caddyserver:masterfrom
VatsalGoel3:feat/tls-wildcard-exact-host-reset
Open

caddyfile: reset wildcard client auth for exact hosts#7867
VatsalGoel3 wants to merge 3 commits into
caddyserver:masterfrom
VatsalGoel3:feat/tls-wildcard-exact-host-reset

Conversation

@VatsalGoel3

@VatsalGoel3 VatsalGoel3 commented Jul 9, 2026

Copy link
Copy Markdown

Assistance Disclosure

AI/LLM assistance was used via OpenAI Codex to help draft the adapter change, fixture, and test workflow. I reviewed the diff, understand the code being submitted, and verified it with the tests listed above.

Summary

  • Add a Caddyfile adapter fixture for wildcard TLS client auth shadowing an exact hostname.
  • Emit an exact-host SNI TLS connection policy before matching wildcard client-auth policies.
  • Preserve wildcard client authentication while letting explicitly configured exact hosts use default TLS behavior.

Tests

  • go test ./caddytest/integration -run 'TestCaddyfileAdaptToJSON/tls_wildcard_exact_host_resets_client_auth'
  • go test ./caddyconfig/httpcaddyfile ./caddytest/integration
  • go test -race -short ./caddyconfig/httpcaddyfile ./caddytest/integration

Assistance Disclosure

OpenAI Codex generated the initial fixture and adapter implementation. I submitted the initial diff before reviewing it thoroughly. I have since reviewed every changed line, verified the behavior, and rerun the listed tests.

@francislavoie

francislavoie commented Jul 10, 2026

Copy link
Copy Markdown
Member

I reviewed the diff

lmao, I don't think you did.

image

@VatsalGoel3

Copy link
Copy Markdown
Author

My bad lol, have corrected

@francislavoie

francislavoie commented Jul 10, 2026

Copy link
Copy Markdown
Member

https://github.com/caddyserver/caddy/blob/master/AGENTS.md#ai-contribution-rules

Also you have two assistance disclosures. lol.

It's not clear what this issue is in reference to. Is there an issue or thread this addresses?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants