Open
Conversation
Owner
c9s
commented
Aug 31, 2023
- rename Add() to AddProfit() or AddTrade() so that we can apply interface here
|
Welcome back! @c9s, This pull request may get 344 BBG. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1296 +/- ##
=======================================
Coverage 21.28% 21.28%
=======================================
Files 596 596
Lines 43933 43933
=======================================
Hits 9349 9349
Misses 33907 33907
Partials 677 677
Continue to review full report in Codecov by Sentry.
|
046ed88 to
4a3b0bc
Compare
|
Re-estimated karma: this pull request may get 343 BBG |
4a3b0bc to
2d915ee
Compare
73d07cd to
fb34a45
Compare
- rename Add() to AddProfit() or AddTrade() so that we can apply interface here
fb34a45 to
8dc9b95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.