Add Initial Objects#13
Open
JonahCWilson wants to merge 1 commit into
Open
Conversation
|
Makes sense to me. Like the logic behind the API connection class. If for no other reason then making it easier if we have to move to a v2 api in the future being able to change the version in one place instead of several. |
lathomas64
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial class definitions for some of the objects in the OverDrive Indexer.
What I've learned:
VAR is used for values that are mutable and can be reassigned.
VAL is used for Immutable Values which are only assigned once.
I'm writing most of this by hand rather than have AI generate it, as that's how you learn, but I have been attempting to do it is the most "Kotlin-ish" way possible. E.g. while it's entirely possible to write getters and settings for every property, you normally shouldn't unless there's specific logic you need (see the id field in OverDriveRecordInfo)
The OverDriveAPIConnection was the start of a thought process, we should move that logic into its own class and isolate it. I think we can also write some logic to separate out the interspersed PreparedStatements.