Fix pybullet NumPy API pointer types and camera buffer sizes - #4800
Open
Fstarnb wants to merge 1 commit into
Open
Fix pybullet NumPy API pointer types and camera buffer sizes#4800Fstarnb wants to merge 1 commit into
Fstarnb wants to merge 1 commit into
Conversation
Cast dimension arrays when calling PyArray_SimpleNew so stricter C compilers accept the NumPy C API. Also use element sizes for depth and segmentation memcpy in the obsolete camera image path. Fixes bulletphysics#4796.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Building
pybullet.cwith stricter C compilers fails with incompatible pointer type errors aroundPyArray_SimpleNew(reported on Raspberry Pi and similar toolchains).Cast the dimension arrays to
const npy_intp *at both camera-image call sites. Also correct the obsolete camera image path so depth/segmentationmemcpyuses element sizes (sizeof(float)/sizeof(int)), matching the primary path.Test plan
PyArray_SimpleNewsitesFixes #4796.