Skip to content

Fix pagination return value in request method #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mo5h wants to merge 1 commit into from
Closed

Fix pagination return value in request method #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions lib/oktakit/client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,9 +185,7 @@ def request(method, path, data:, query:, headers:, accept:, content_type:, pagin
uri = URI::DEFAULT_PARSER.escape("/api/v1" + path.to_s)
@last_response = resp = sawyer_agent.call(method, uri, data, options)

response = [resp.data, resp.status]
response << absolute_to_relative_url(resp.rels[:next]) if paginate
response
[resp.data, resp.status, paginate ? absolute_to_relative_url(resp.rels[:next]) : nil]
end

def sawyer_agent
Expand Down
Loading