wl-copy: ignore SIGINT when backgrounded#220
Open
krobelus wants to merge 1 commit intobugaevc:masterfrom
Open
Conversation
Given a command like
echo foo | wl-copy
Unlike bash, the fish shell puts wl-copy in the shell's process
group [1], which can be observed with "ps -o pid,pgid,comm,args".
On VSCode's integrated terminal, this causes the issue that Control+C
will kill wl-copy, clearing the clipboard. fish has worked around
this[2] but still we should fix the command described above.
I'll try to look into changing the fish behavior but chances are
it's complicated.
Let's block SIGINT and SIGQUIT in the background process.
This will make wl-copy behave as if launched as
bash -c "wl-copy &"
because according to Bash documentation[3] that's how background
commands in noninteractive shells should behave:
> When job control is not in effect, asynchronous commands ignore
> SIGINT and SIGQUIT in addition to these inherited handlers.
fish implements this too, but the bug happens on interactive shells.
[1]: fish-shell/fish-shell@f3736e8
[2]: fish-shell/fish-shell@b3444ea
[3]: https://www.gnu.org/software/bash/manual/html_node/Signals.html
Author
|
alternatively we could call |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given a command like
Unlike bash, the fish shell puts wl-copy in the shell's process
group 1, which can be observed with "ps -o pid,pgid,comm,args".
On VSCode's integrated terminal, this causes the issue that Control+C
will kill wl-copy, clearing the clipboard. fish has worked around
this2 but still we should fix the command described above.
I'll try to look into changing the fish behavior but chances are
it's complicated.
Let's block SIGINT and SIGQUIT in the background process.
This will make wl-copy behave as if launched as
because according to Bash documentation3 that's how background
commands in noninteractive shells should behave:
fish implements this too, but the bug happens on interactive shells.