Improve buf curl error message on trailing input - #4687
Merged
Merged
Conversation
Contributor
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
anuraaga
approved these changes
Sep 17, 2026
| func TestVerifySingleRequest(t *testing.T) { | ||
| t.Parallel() | ||
| resolver := newTestResolver(t) | ||
| // Download is server-streaming: it still accepts only a single request, and |
Contributor
There was a problem hiding this comment.
Perhaps it's in a different file since I don't see it in this one, otherwise should we have a test case for normal unary too? Similarly maybe cases for second message succeeding to parse unless they're elsewhere
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small improvement to the error message for
buf curlon trailing data misinterpreted as a multi-stream message.Closes #3944