Add additionalTextEdit for trailing ; in import statement
#4110
Conversation
It's nice to send this along if it doesn't exist; makes the import valid. Ref: #4103 (review)
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
| }, | ||
| End: protocol.Position{ | ||
| Line: position.Line, | ||
| Character: math.MaxUint32, |
There was a problem hiding this comment.
Doesn't seem to work in neovim/vim. I tried the following change:
+ importRange := reportSpanToProtocolRange(declImport.Span())
- Start: protocol.Position{
- Line: position.Line,
- Character: math.MaxInt32 - 1,
- },
- End: protocol.Position{
- Line: position.Line,
- Character: math.MaxUint32,
- },
+ Start: importRange.End,
+ End: importRange.End,
But that doesn't look like it works either (works in VSCode).
There was a problem hiding this comment.
It works for me in neovim, at least (I can check vim); with both mini.completion & nvim-cmp. (The trick is to make sure you're using the plugin's mapping for complete, e.g. <C-y> for nvim-cmp, assuming you've set up the defaults.)
There was a problem hiding this comment.
unfortunately, with vim + https://github.com/prabirshrestha/asyncomplete.vim + https://github.com/prabirshrestha/asyncomplete-lsp.vim, it looks like the plugin has a bug where it applies the additionalTextEdit, but then also inserts the completion again?:
import "google/protobuf/type.proto";import "google/protobuf/type.proto"Going to see about reporting upstream.
There was a problem hiding this comment.
It's nice to send this along if it doesn't exist; makes the import valid.
Ref: #4103 (review)