Conversation
modal.js
Outdated
There was a problem hiding this comment.
if you're changing this logic, you should remove the other container = angular.element(config.container || document.body),
|
I don't really understand the problem. This might be a good fix, but this needs an accompanying test case showing where the existing logic falls short. |
|
@btford Sure, I will add a test case. |
|
I think it's not the issue of I followed the example in README, because the When I jump into the others(also injects the thanks |
|
Makes sense. I'm not particularly opposed to this change, but it seems like it might be better to just create a new modal instance for each controller. |
hi,
I found
containerwould be invalid when route changed, so I just select it every time whenconfig.containeris set by user. Does that make sense?thanks.