Skip to content

fix: undefined variables and wrong names - #6

Open
GlintonLiao wants to merge 1 commit into
brunosimon:masterfrom
GlintonLiao:master
Open

fix: undefined variables and wrong names#6
GlintonLiao wants to merge 1 commit into
brunosimon:masterfrom
GlintonLiao:master

Conversation

@GlintonLiao

Copy link
Copy Markdown

There are some mistakes in the template:

  1. inside Experience.js, there is no rendererInstance attribute in the class, so it's passing undefined to the Render().
  2. inside Loader.js, the class name is wrong.
  3. There is no DracoLoader.releaseDecoderModule() method in this version, it became an instance method dispose() instead.

None of these mistakes will have an impact on the final result, but it's always good to fix them :)

@GlintonLiao GlintonLiao changed the title fix: undefined virables and wrong names fix: undefined variables and wrong names Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant