Skip to content

fix: update sha.js to ^2.4.12 to address CVE-2025-9288#33

Closed
fglsn wants to merge 1 commit intobrowserify:masterfrom
fglsn:bump-sha-js-dependency
Closed

fix: update sha.js to ^2.4.12 to address CVE-2025-9288#33
fglsn wants to merge 1 commit intobrowserify:masterfrom
fglsn:bump-sha-js-dependency

Conversation

@fglsn
Copy link

@fglsn fglsn commented Aug 22, 2025

  • Bumps sha.js from ^2.4.11 to ^2.4.12
  • Fixes security vulnerability where missing input type checks could lead to hash state rewind and value miscalculation
  • CVE-2025-9288: GHSA-95m3-7q98-8xr5

- Bumps sha.js from ^2.4.11 to ^2.4.12
- Fixes security vulnerability where missing input type checks
  could lead to hash state rewind and value miscalculation
- CVE-2025-9288: GHSA-95m3-7q98-8xr5
@ljharb
Copy link
Member

ljharb commented Aug 22, 2025

There is never a need for PRs like this - all you need to do is update your lockfile.

@ljharb ljharb closed this Aug 22, 2025
@gausie
Copy link

gausie commented Aug 23, 2025

Is it not useful to have these updates in place for when a new version should be released?

@ljharb
Copy link
Member

ljharb commented Aug 24, 2025

Nope! not at all. Whenever I do a new release, I always update deps beforehand. It's basically never helpful for a non-maintainer to update in-range dependencies, on any open source project.

@fglsn
Copy link
Author

fglsn commented Aug 25, 2025

There is never a need for PRs like this - all you need to do is update your lockfile.

Sorry for the noise then.

The issue is most users get this transitively through other packages, so they can't control the sha.js version directly. Lockfiles may stick with vulnerable 2.4.11 without this change. The idea was that new installations would get the secure version by default.

We'll handle it with overrides on our end.

@ljharb
Copy link
Member

ljharb commented Aug 25, 2025

You shouldn't need overrides - npm audit fix, or tools like renovate/dependabot, can handle it for you just fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants