Conversation
…e sea binary. Now it just pulls the binary. docs: Added docs
There was a problem hiding this comment.
2 issues found across 20 files (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="examples/pydoll_tab_example.py">
<violation number="1">
P3: Fix the docstring typo (`ePage.getFrameTree`) so the CDP method name is correct.</violation>
<violation number="2">
P2: Ensure the session is ended before exiting early when `cdp_url` is missing to avoid leaking a remote session.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name=".github/workflows/publish-pypi.yml">
<violation number="1" location=".github/workflows/publish-pypi.yml:95">
P2: `RELEASE_TAG` includes `/` (stagehand-server/v…), but the GitHub API call uses it unencoded. This can turn the slash into a path separator and 404 the release lookup. URL-encode the tag before building the `/releases/tags/{tag}` URL.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: CI was pulling the entire stagehand repo and re-creating the node SEA binary. Now it just pulls the binary.
fix: No longer using a STAGEHAND_TAG var that we have to set in github. Instead, it just pulls the latest
stagehand-servergithub release.docs: Added docs
Summary by cubic
Speeds up and simplifies the PyPI publish workflow by downloading the prebuilt Stagehand server binary from the latest GitHub Release instead of cloning and rebuilding from source. Removes the stagehand_tag input and STAGEHAND_TAG repo var (auto-selects latest), drops Node/pnpm build steps, and adds RELEASE_WORKFLOWS.md documenting the release flow and required secrets.
Written for commit 0cd451c. Summary will update on new commits.