Fix call signature for local screenshot#108
Closed
conorbranagan wants to merge 1 commit intobrowserbase:mainfrom
conorbranagan:conor/fix-local-screenshot
Closed
Fix call signature for local screenshot#108conorbranagan wants to merge 1 commit intobrowserbase:mainfrom conorbranagan:conor/fix-local-screenshot
conorbranagan wants to merge 1 commit intobrowserbase:mainfrom
conorbranagan:conor/fix-local-screenshot
Conversation
This function takes a set of kwargs rather than a dictionary.
Author
|
Ah! I had missed #106, will close. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
why
This function takes a set of kwargs rather than a dictionary, the call was failing.
what changed
test plan
Added a new test for this and verified this locally in the work I'm doing using this library.