when I start a new browser use desktop instance, I shouldnt get a "wi…

[Cheggin]

…ndow already opened error".

also, when I need to update and double click a new dmg or something if I install a separate one, then it should auto-update current window.

Summary

Test plan

• npm run lint passes
• npm run typecheck passes
• npm run test passes (unit + integration)
• New code has tests (per D1 directive — TDD, ≥80% coverage on new src/main/src/shared modules)
• Python changes: pytest + ruff check + mypy pass
• Manual QA in npm run dev for UI-facing changes

Screenshots / recordings

Risk + rollback

---

Summary by cubic

Stops the “window already opened” alert on duplicate launches. Second launches now exit, and the primary instance focuses an existing window or recreates the right one.

• Bug Fixes

  • Enforce single instance via electron’s app.requestSingleInstanceLock; lock loser calls app.exit(0).
  • On second-instance, focus the best available window (shell, onboarding, or last focused); if none exist, open shell or create onboarding based on account state.

• Refactors

  • Remove version-aware takeover; duplicate-launch handling is version-agnostic for predictable macOS behavior.

^{Written for commit 7e41114. Summary will update on new commits.}

[cubic-dev-ai]

1 issue found across 3 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="app/src/main/startup/singleInstance.ts">

<violation number="1" location="app/src/main/startup/singleInstance.ts:71">
P1: Prerelease versions are compared lexically instead of SemVer precedence, which can misidentify which instance is newer (e.g., `beta.10` vs `beta.2`).</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.}

[Cheggin]

@cubic review this entire pr pls

[cubic-dev-ai]

@cubic review this entire pr pls

@Cheggin I have started the AI code review. It will take a few minutes to complete.

[cubic-dev-ai]

1 issue found across 3 files (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="app/src/main/index.ts">

<violation number="1" location="app/src/main/index.ts:46">
P1: This change removes newer-instance handoff and always keeps the currently running instance, so manual installs/updates cannot take over when an older process is already open.</violation>
</file>

_{Tip: Review your code locally with the cubic CLI to iterate faster.
Fix all with cubic.}

[cubic-dev-ai]

P1: This change removes newer-instance handoff and always keeps the currently running instance, so manual installs/updates cannot take over when an older process is already open.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At app/src/main/index.ts, line 46:

<comment>This change removes newer-instance handoff and always keeps the currently running instance, so manual installs/updates cannot take over when an older process is already open.</comment>

<file context>
@@ -48,22 +41,9 @@ crashReporter.start({
-if (!app.requestSingleInstanceLock(singleInstanceLaunchData)) {
+// Enforce a single running instance. The lock loser exits, while the primary
+// process handles `second-instance` by focusing or recreating its main window.
+if (!app.requestSingleInstanceLock()) {
   app.exit(0);
 }
</file context>

_{Tip: Review your code locally with the cubic CLI to iterate faster.}

[cubic-dev-ai]

No issues found across 1 file