Skip to content

ci: run unit tests before releases - #844

Open
jamiekostelac-cyber wants to merge 2 commits into
browser-use:mainfrom
jamiekostelac-cyber:codex/browser-harness-ci-tests
Open

jamiekostelac-cyber wants to merge 2 commits into
browser-use:mainfrom
jamiekostelac-cyber:codex/browser-harness-ci-tests

Conversation

@jamiekostelac-cyber

@jamiekostelac-cyber jamiekostelac-cyber commented Sep 23, 2026 •

Copy link
Copy Markdown

Fixes #679

Add a reusable cross-platform unit-test workflow for pull requests, pushes to main, and release calls. The release workflow now gates PyPI publishing on the test job. Add the pytest optional dependency and document the local command.

Verification:

  • Workflow YAML parse: passed
  • Unit suite: 266 passed, 1 skipped
  • Fresh independent Luna audit: PASS

Summary by cubic

Fixes #679 by adding a reusable unit-test workflow that gates releases on the unit suite. The workflow runs on Linux, macOS, and Windows for Python 3.11 and 3.12 on PRs, main pushes, and release calls, and the PyPI publish job now waits for these tests. Also adds pytest as a test optional dependency, documents local testing in CONTRIBUTING.md, installs the mcp extra in the test job, and makes test mocks Windows-compatible.

Written for commit 4453443. Summary will update on new commits.

Review in cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 4 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name=".github/workflows/test.yml">

<violation number="1" location=".github/workflows/test.yml:16">
P1: Adding `windows-latest` makes this workflow fail before collecting tests: `tests/unit/test_admin.py` monkeypatches Unix-only `os.killpg`, which does not exist on Windows. Because `release.yml` makes `publish` depend on this matrix, every release is blocked until those POSIX-only tests are guarded or made Windows-safe.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread .github/workflows/test.yml
Comment thread .github/workflows/test.yml Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread .github/workflows/test.yml
@jamiekostelac-cyber

Copy link
Copy Markdown
Author

Review follow-up: the Windows P1 is addressed in commit 4453443. All four Unix-only os.killpg monkeypatches now use raising=False, so the Windows test module can collect without requiring that attribute. The current Cubic check, GitGuardian, and skill-review checks pass. Local verification with both extras: 268 passed. The release gate remains protected by the six-job matrix timeout.

Copy link
Copy Markdown
Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@jamiekostelac-cyber

Copy link
Copy Markdown
Author

titan-review-substitute bot=codex sha=4453443f7596d085aab8dd4e52c9be018b2ed7bd tool=codex-cli

@jamiekostelac-cyber

Copy link
Copy Markdown
Author

The test workflow run 35897798753 for head 4453443 is still action_required and ran no jobs. Could a repository admin approve the run so CI can collect its test evidence?

@jamiekostelac-cyber

Copy link
Copy Markdown
Author

Correction: GitHub documents workflow approval as an action available to repository maintainers with write access; an administrator is not necessarily required. The current ask is for any maintainer with write access to approve run 35897798753. Source: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/approve-runs-from-forks

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No CI runs the test suite — release.yml publishes to PyPI with no test gate

1 participant