feat(threads): implement account-level insights - #151
Closed
murtaja1 wants to merge 1 commit into
Closed
Conversation
get_account_metrics had no override, so every Threads account skipped account-level analytics entirely (NotImplementedError). Add it against me/threads_insights with metric=views,followers_count: views is a daily time-series metric (Threads returns it under values[]) and followers_count is a lifetime total (returned under total_value.value) — the same two shapes parse_insights_response already handles for the other Meta-backed providers, reused here rather than re-implemented. A day with no view activity simply omits the views entry, which maps to 0 rather than being dropped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_account_metrics had no override for Threads, so every Threads account skipped account-level analytics entirely -- it raised NotImplementedError, leaving the account with no follower/views history at all. Noticed in production while auditing which providers actually populate account-level analytics.
Fix: add it against me/threads_insights with metric=views,followers_count. views is a daily time-series metric (Threads returns it under values[]) and followers_count is a lifetime total (returned under total_value.value) -- the same two response shapes parse_insights_response already handles for the other Meta-backed providers, reused here rather than re-implemented. A day with no view activity simply omits the views entry, which maps to 0 rather than being dropped.
Tested: new unit tests in tests/providers/test_threads.py covering the request shape, the two response shapes (time-series views + lifetime followers_count), and a day with no views activity. Full test_threads.py passes.