[perf] use StackVector to save memory & CPU #553
Draft
+61
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Rust Benchmark
| Benchmark suite | Current: 0558c35 | Previous: fb302a1 | Ratio |
|---|---|---|---|
rule-match-browserlike/brave-list |
1924466696 ns/iter (± 3388282) |
1984823359 ns/iter (± 5983067) |
0.97 |
rule-match-first-request/brave-list |
1094744 ns/iter (± 4865) |
1122488 ns/iter (± 12800) |
0.98 |
blocker_new/brave-list |
147191098 ns/iter (± 712999) |
149727024 ns/iter (± 339770) |
0.98 |
blocker_new/brave-list-deserialize |
23633296 ns/iter (± 154619) |
26513534 ns/iter (± 261982) |
0.89 |
memory-usage/brave-list-initial |
10212216 ns/iter (± 3) |
10212216 ns/iter (± 3) |
1 |
memory-usage/brave-list-initial/max |
63147535 ns/iter (± 3) |
63149135 ns/iter (± 3) |
1.00 |
memory-usage/brave-list-initial/alloc-count |
1113885 ns/iter (± 3) |
1231721 ns/iter (± 3) |
0.90 |
memory-usage/brave-list-1000-requests |
2666990 ns/iter (± 3) |
2666990 ns/iter (± 3) |
1 |
memory-usage/brave-list-1000-requests/alloc-count |
69282 ns/iter (± 3) |
71425 ns/iter (± 3) |
0.97 |
url_cosmetic_resources/brave-list |
190555 ns/iter (± 914) |
190888 ns/iter (± 667) |
1.00 |
cosmetic-class-id-match/brave-list |
3374902 ns/iter (± 903498) |
3417585 ns/iter (± 941841) |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
atuchin-m
force-pushed
the
add-stack-vector
branch
from
d1f4e55 to
0558c35
Compare
| pub fn into_vec(self) -> Vec<T> { | ||
| let mut v = Vec::with_capacity(self.size); | ||
| for i in 0..self.size { | ||
| v.push(unsafe { self.data[i].assume_init_read() }); |
There was a problem hiding this comment.
reported by reviewdog 🐶
[opengrep] Detected 'unsafe' usage, please audit for secure usage
Source: https://semgrep.dev/r/rust.lang.security.unsafe-usage.unsafe-usage
Cc @thypon @kdenhartog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
memory-usage/brave-list-initial/alloc-count -9%