Skip to content

Add dependencies to quiet warnings and prepare for Ruby 3.5 #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mohamedhafez wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add dependencies to quiet warnings and prepare for Ruby 3.5 #255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cbbfd05
Add dependencies to quiet warnings and prepare for Ruby 3.5
mohamedhafez Oct 29, 2025
c6ee2b8
Also add new gems to Gemfile
mohamedhafez Oct 30, 2025
fcdaac9
Update CHANGELOG with unreleased changes
mohamedhafez Oct 30, 2025
dcee268
Merge branch 'master' into patch-1
mohamedhafez Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Changelog

## Unreleased
- Add gems that are no longer standard libraries / default gems to Gemfile and gemspec

## 4.33.1
- Bug fix for Nokogiri XML parsing

Expand Down
4 changes: 4 additions & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ source "https://rubygems.org"
gem "builder", "3.2.4"
gem "nokogiri", "~> 1.12"
gem "require_all", "3.0.0"
gem "base64", ">= 0.3.0"
gem "bigdecimal", ">= 3.3.1"
gem "logger", ">= 1.7.0"
gem "ostruct", ">= 0.6.3"

group :development do
gem "pry", "0.13.1"
Expand Down
4 changes: 4 additions & 0 deletions braintree.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ Gem::Specification.new do |s|
s.files = Dir.glob ["README.rdoc", "LICENSE", "lib/**/*.{rb,crt}", "spec/**/*", "*.gemspec"]
s.add_dependency "builder", ">= 3.2.4"
s.add_dependency "rexml", ">= 3.1.9" # Use rexml version associated with minimum supported Ruby version
s.add_dependency "base64", ">= 0.3.0"
s.add_dependency "bigdecimal", ">= 3.3.1"
s.add_dependency "logger", ">= 1.7.0"
s.add_dependency "ostruct", ">= 0.6.3"
s.required_ruby_version = ">=2.6.0"
s.metadata = {
"bug_tracker_uri" => "https://github.com/braintree/braintree_ruby/issues",
Expand Down