Skip to content

Fix errors handle on plan create #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
franjid wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix errors handle on plan create #224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
71e9a7f
Replace 'errors' with expected 'api_error_response'
franjid Dec 14, 2021
283d4ad
Update Changelog with last issue fixed
franjid Dec 14, 2021
9b08137
Update CHANGELOG.md
Dani-Kirby Sep 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## Unreleased

* Fix issue where validation errors from creating a plan were not surfaced (#223)

## 4.5.0
* Add plan create/update/find API endpoint
* Add support for `TransactionReview` webhook notification
Expand Down
6 changes: 3 additions & 3 deletions lib/braintree/plan_gateway.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,10 +106,10 @@ def _do_create(path, params) # :nodoc:
response = @config.http.post("#{@config.base_merchant_path}#{path}", params)
if response[:plan]
SuccessfulResult.new(:plan => Plan._new(@gateway, response[:plan]))
elsif response[:errors]
ErrorResult.new(@gateway, response[:errors])
elsif response[:api_error_response]
ErrorResult.new(@gateway, response[:api_error_response])
else
raise UnexpectedError, "expected :plan or :errors"
raise UnexpectedError, "expected :plan or :api_error_response"
end
end
end
Expand Down