ci: fix asset/readme update workflow (IGNORE_OTHER_FILES)#154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Plugin asset/readme update workflow has been failing on every push to master (for years) with
🛑 Other files have been modified; changes not deployed.Cause
The
10up/action-wordpress-plugin-asset-updateaction, in its default mode, copies the whole repo into SVNtrunk/(respecting.distignore) and aborts if anything other thanreadme.txtdiffers. Our SVNtrunk/has drift vs. the repo — builtadmin/dashboard/assets/build/*(gitignored) andpackage-lock.json(in.distignore) exist in trunk but not in the repo — so the guard always trips.Fix
Set
IGNORE_OTHER_FILES: trueso the action copies onlyreadme.txt+.wordpress-orgassets and ignores unrelated trunk files (documented flag). Actual code still ships viapush-to-deploy.ymlon tags. This lets theTested up to: 7.0readme bump actually reach WordPress.org.