Ad7173 nitpicks #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caught some missing dots and duplicate wire segments. Added dummy value "." to devices where ERC requires value. Color might be more informative value for LEDs. It would be better to resolve I/O mapping conflicts than to approve ERC errors. Signed-off-by: Christoph Maier <[email protected]>
Signed-off-by: Christoph Maier <[email protected]>
This is probably an artifact of me not using the auto router. Separate commit, so it can be undone. Signed-off-by: Christoph Maier <[email protected]>
(may be platform specific, integrate with caution) Signed-off-by: Christoph Maier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes three lines from the board file:
that may be useful for Eagle 7.4.0. In that case, they shouldn't be deleted. This pull request also adds a (Linux specific) eagle.epf project file that may be incompatible with others' versions.