Fix minor download button issue #29
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix an issue with the download button looking wrong on certain screens.
Member
Error: Contributor Licence Agreement Signature MissingPlease sign the Contributor Licence Agreement by clicking the following link. ### Error: Contributor Licence Agreement Signature Missing The following commiter(s) has not signed the Contributor Licence Agreement: ScanuNicco Please sign the Contributor Licence Agreement by clicking the following link. |
1 similar comment
Member
Error: Contributor Licence Agreement Signature MissingPlease sign the Contributor Licence Agreement by clicking the following link. ### Error: Contributor Licence Agreement Signature Missing The following commiter(s) has not signed the Contributor Licence Agreement: ScanuNicco Please sign the Contributor Licence Agreement by clicking the following link. |
abose
force-pushed
the
gh-pages
branch
3 times, most recently
from
63351bf to
62bd239
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with the download button looking wrong on certain screens. When I sized my browser window to be one half of my 1920 x 1200 screen, the button is too tall..
This is being caused by the spinner moving to the next line when the button gets too narrow:
I fixed this by adding a minimum width of 150px but it might be better to change the width at which the mobile view is used