ADIOS2 format writer#348
Merged
Merged
Conversation
`save` can now write datasets to Adios2 .bp format. Includes a round-trip unit test.
Removing commented-out code, adding docstrings.
ProgressBar works when a Dask task graph is being executed, but that is not the case for write_dataset_bp.
The ADIOS2 reader in BOUT++ only handles int32 integers, so provide an option to convert all output integers to this size.
Passes through to ADIOS write_dataset_bp
dschwoerer
reviewed
Jun 10, 2026
Tests require these packages, so fail early if they're missing.
dschwoerer
approved these changes
Jun 15, 2026
dschwoerer
left a comment
dschwoerer
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
It might be nice to avoid some of the branching, but I suppose that is fine as is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows datasets to be written to ADIOS2 ".bp" outputs.
Includes round-trip unit test.