Fix tests again#587
Open
mikekryjak wants to merge 2 commits into
Open
Conversation
Explain why outer cells neglected.
mikekryjak
force-pushed
the
fix-tests-again
branch
from
350d734 to
1dc35d7
Compare
Consistent data checking and generation. Removed the odd workaround for the new xHermes selection to go from "selection to indices". The guard cells have changed since the last time the data was generated, so now the check and data generation are without guards and I've regenerated the data. This is appropriate as time derivatives are not evolved in the guard cells and may change arbitrarily.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #587 +/- ##
==========================================
- Coverage 49.32% 49.08% -0.25%
==========================================
Files 96 96
Lines 10029 10038 +9
Branches 1453 1452 -1
==========================================
- Hits 4947 4927 -20
- Misses 4587 4606 +19
- Partials 495 505 +10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit (c1f5915) introduced a workaround for the new xHermes selectors which blended the new selector system with old style index selection. This was a narrow fix for the test but broke it when
gen_data=True.I also spent a bit of time confusing myself about why
2D-recyclingomits edge domain cells, thinking something could be wrong. I update comments/docs to make it clearer for the next person. Prek made formatting changes to the rest of the file as well.