WIP: Updating to BOUT++ with template expressions#585
Open
bendudson wants to merge 2 commits into
Open
Conversation
Explicitly evaluate BinaryExpr expressions into fields when needed.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #585 +/- ##
==========================================
- Coverage 49.32% 49.29% -0.04%
==========================================
Files 96 96
Lines 10029 10046 +17
Branches 1453 1455 +2
==========================================
+ Hits 4947 4952 +5
- Misses 4587 4599 +12
Partials 495 495 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
PetscLib throws if `type` exists in the `petsc` section. This was created by iterating over all sections and checking `options["type"].isValue()`. Instead use `options.isSet()`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest BOUT++
nextuses BinaryExpr template expressions to merge arithmetic operations.boutproject/BOUT-dev#3385
Work In Progress to enable compilation and performance testing.