Add ionising core feature#576
Open
sun51027 wants to merge 29 commits into
Open
Conversation
Collaborator
|
I see that this PR contains this one: #451 Once I merge #556, we can point this PR at master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Principle of the “ionising core” feature: Neutrals that reach the core boundary are removed from the domain and their flux is added to the boundary condition on the flux of ions from the core. In other words, neutrals are ionised when hit the core boundary and turn back as ions.
It aims to make the neutral core boundary treatment more physical, as well as to replicate the core boundary feature used in SOLPS.
New features are added:
ionising_core=true: remove neutral particles/momentum/energy flow toward the core boundary, while neutral particle flow return as ion particle flow.ionise_as: ion species, e.g.d->d+,t->t+ionising_core_return_mom_energy=true: neutral momentum/energy flow will return as ion momentum/energy flowionising_core_iz_energy_loss: User defined variable for electron energy pay for ionisation. The default value is 13.6 (eV). Can be set to 0 to disable this feature.WIP: Ionisation at core: neutral goes into core, coming back as ion
To-do
Renamed module from
core_ionising→ionising_coreAdd flag
ionisation_energy_losstrue: cost energy from electrons to ionise neutralelectron energy source -= ionise_particle_flow / volionisation_energy_loss→ionising_core_iz_energy_lossAdd flag
only_particle_flow(SOLPS-like) (Use parallel momentum instead of one-way momentum flux (radial momentum)
Write and pass regression / unit tests
Documentation