Make Div_par_fvv_heating like Div_par_fvv - #3456
Open
dschwoerer wants to merge 1 commit into
Open
Conversation
Member
|
I don't quite understand the title/commit message. Is this something like "use pre-calculated cell areas in |
Div_par_fvv has been changed to use pre-computed cell areas. As Div_par_fvv_heating is used to compute the numerical heating of Div_par_fvv, it is imporent that the numerical details, like how the cell face areas are computed, so that they give matching results. Thanks to Mike Kryjak, who noticed this issue while reviewing a Hermes-3 PR.
dschwoerer
force-pushed
the
div_par_fvv_heating_area
branch
from
August 14, 2026 07:21
2cff76e to
be2ff91
Compare
Contributor
Author
|
Ah, yes, sorry. I have rewritten the commit message. Is this sufficient? Use pre-computed cell areas for Div_par_fvv_heatingDiv_par_fvv has been changed to use pre-computed cell areas. As Thanks to Mike Kryjak, who noticed this issue while reviewing a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.