BM-2988: enable gcs feature by default#2000
Draft
capossele wants to merge 5 commits into
Draft
Conversation
github-actions
Bot
changed the title
willpote
reviewed
May 19, 2026
| bonsai-sdk = { workspace = true } | ||
| boundless-assessor = { workspace = true } | ||
| boundless-market = { workspace = true, features = ["prover_utils"] } | ||
| boundless-market = { workspace = true, features = ["prover_utils", "gcs"] } |
Contributor
There was a problem hiding this comment.
I was thinking we'd model at broker level:
[features]
default = ["gcs"]
gcs = ["boundless-market/gcs"]
[dependencies]
boundless-market = { workspace = true, features = ["prover_utils"] }so that you can still build broker without GCS if you like via cargo build -p broker --no-default-features
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
gcsfeature to the broker and indexer'sboundless-marketdependency so deployed binaries can fetchgs://image and input URLs out of the box. Until now, both crates were built with only thes3default feature, which caused everygs://URL to fail at the URL-scheme dispatcher before any auth was attempted.