Enable formating checks fort typst files#324
Merged
Merged
Conversation
Reformat freshly integrated typst slides with the following command:
$ find . -name "*typ" -exec typstyle -i {} \;
No special check has been done for the "common" slides defining the
theme, more thorough checks are done for the next commits involving some
complete slide decks.
Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>
Reformat freshly integrated typst slides with the following command:
$ find . -name "*typ" -exec typstyle -i {} \;
The new typst slides have been built before and after the re-formatting,
and the difference has been inspected with the following command:
$ diff-pdf slides-pre.pdf slides-post.pdf -s -m --output-diff=diff.pdf
No visual difference is observed on the training slides.
Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>
Reformat freshly integrated typst slides with the following command:
$ find . -name "*typ" -exec typstyle -i {} \;
The new typst slides have been built before and after the re-formatting,
and the difference has been inspected with the following command:
$ diff-pdf slides-pre.pdf slides-post.pdf -s -m --output-diff=diff.pdf
No visual difference is observed on the training slides.
Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>
Reformat freshly integrated typst slides with the following command:
$ find . -name "*typ" -exec typstyle -i {} \;
The new typst slides have been built before and after the re-formatting,
and the difference has been inspected with the following command:
$ diff-pdf slides-pre.pdf slides-post.pdf -s -m --output-diff=diff.pdf
No visual difference is observed on the training slides.
Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>
Reformat freshly integrated typst slides with the following command:
$ find . -name "*typ" -exec typstyle -i {} \;
The new typst slides have been built before and after the re-formatting,
and the difference has been inspected with the following command:
$ diff-pdf slides-pre.pdf slides-post.pdf -s -m --output-diff=diff.pdf
No visual difference is observed on the training slides.
Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>
Reformat freshly integrated typst slides with the following command:
$ find . -name "*typ" -exec typstyle -i {} \;
The new typst slides have been built before and after the re-formatting,
and the difference has been inspected with the following command:
$ diff-pdf slides-pre.pdf slides-post.pdf -s -m --output-diff=diff.pdf
No visual difference is observed on the training slides.
Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>
Reformat freshly integrated typst slides with the following command:
$ find . -name "*typ" -exec typstyle -i {} \;
The new typst slides have been built before and after the re-formatting,
and the difference has been inspected with the following command:
$ diff-pdf slides-pre.pdf slides-post.pdf -s -m --output-diff=diff.pdf
The only slight difference is on slide 169 (BCC Tools example), which is
slightly very shifted upwards, but the difference is only visible with
diff-pdf, visually the slides look the same, so the diff is tolerable.
Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>
Reformat freshly integrated typst slides with the following command:
$ find . -name "*typ" -exec typstyle -i {} \;
The new typst slides have been built before and after the re-formatting,
and the difference has been inspected with the following command:
$ diff-pdf slides-pre.pdf slides-post.pdf -s -m --output-diff=diff.pdf
No visual difference is observed on the training slides.
Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>
Reformat freshly integrated typst slides with the following command:
$ find . -name "*typ" -exec typstyle -i {} \;
The new typst slides have been built before and after the re-formatting,
and the difference has been inspected with the following command:
$ diff-pdf slides-pre.pdf slides-post.pdf -s -m --output-diff=diff.pdf
There is a slight difference spotted on slide 248 (Example: from
ConnMann), but it is only visible in diff-pdf, not when putting the two
slide decks next to each other, so it is tolerable.
Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>
Some standalone slides, despite not being used in one of the converted trainings, have been converted to typ. Drop those unused slides. Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>
Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings formatting checks based on typstyle for the new materials written in typst: