github: actions: build in parallel#268
Conversation
|
Why not about building in parallel, but your other commit to update Ubuntu will I believe no longer apply as we updated to Ubuntu 24.04. I don't think we want to use "latest" as this will change "magically" over time, making things not reproducible, and breaking without us actually wanting an update. Could you drop this commit from the PR (it's unrelated to the PR topic anyway) |
|
Hello @tleb, can you update this PR? Or is it no longer relevant and we can close it? |
According to GitHub's documentation, actions have access to 4 CPUs [0]. Exploit those. [0]: https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com>
bac47a0 to
9ad6a69
Compare
|
No it is still relevant, just that it is broken. The goal is to be able to do I read a bit the Makefile this morning, and I think our main issue is with: Lines 243 to 260 in 349470e Notice how shared targets will be attempted in different make processes. How to fix? We should remove this sub-make process instantiation. |
|
Will the typst transition help in building the materials in parallel? Or maybe it is no longer needed given how faster this is now happening? |
|
Most likely no. We still do the sub-make incantation: we have daddy-make spawning N baby-makes each trying to build one slides PDF. The issue is that to build slides they have shared dependencies so baby-makes will all attempt resolving their dependencies at the same time. I say "most likely" because in theory it could work if all targets resist races and build their dependencies "atomically". It is unlikely, and even if it works, it would be wasted efforts. We ought to switch to only one make process (ie no babies involved). |
According to GitHub's documentation, actions have access to 4 CPUs. Exploit those.
Untested. I tried using the act project to run GitHub actions locally but got some errors. Let's see what this PR's actions say.