crates: Add discoverable partition module #1694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request is a great improvement. It introduces a dedicated module for the Discoverable Partitions Specification, centralizing all related GUIDs and logic. This significantly enhances maintainability and correctness by removing hardcoded values scattered across the codebase and ensuring they are aligned with the official specification. The inclusion of a validation test against the spec file is an excellent touch. The overall changes are clean and well-executed.
cgwalters
force-pushed
the
enhance-dps
branch
from
8545d8c to
b8575ae
Compare
This fleshes out what we had with a more rigorous binding to the spec. As part of this though, the ESP constant we had here was uppercase, but the spec version uses lowercase. Add APIs to find a partition by type, comparing case insensitively. Assisted-by: Claude Code Signed-off-by: Colin Walters <[email protected]>
cgwalters
force-pushed
the
enhance-dps
branch
from
b8575ae to
c54054e
Compare
|
ooo. Hooray for the new composefs integration tests catching a bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fleshes out what we had with a more rigorous
binding to the spec.
Assisted-by: Claude Code