CI: Error when Windows CMake test fails and fix RTTI flags in CMake#43
Merged
apolukhin merged 3 commits intoboostorg:developfrom Oct 14, 2025
Merged
CI: Error when Windows CMake test fails and fix RTTI flags in CMake#43apolukhin merged 3 commits intoboostorg:developfrom
apolukhin merged 3 commits intoboostorg:developfrom
Conversation
9010145 to
5b4f039
Compare
Only the exit code of the last command is considered, so make sure CTest is last
Member
|
Many thanks! Merged the PR, will take care of the link fail in a separate PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only the exit code of the last command is considered, so make sure CTest is last
See this failing test with success on CI: https://github.com/boostorg/type_index/actions/runs/18352125278/job/52274666284#step:4:265
Also
-fno-rttiwas used in CMake for Windows too instead of the variable.Also check why that link test fails (because linking succeeds). I'm not sure how it is intended to fail so can't fix it.