Skip to content

More on endianness #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

More on endianness #720

wants to merge 5 commits into from
+35 −19

Conversation

@grisumbras
Copy link
Member

@grisumbras grisumbras commented Jun 12, 2022 •
edited
Loading

Fix #187
Document choosing endianness via macros

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://720.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://720.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://720.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://720.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://720.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

@grisumbras grisumbras force-pushed the endianness-more branch 2 times, most recently from 66ec5c9 to d8df2cc Compare June 12, 2022 11:49
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://720.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

1 similar comment
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://720.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/720/pullrequest.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://720.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/720/pullrequest.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://720.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

@codecov
Copy link

codecov bot commented Jul 9, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.08%. Comparing base (2883ff1) to head (d79a586).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #720   +/-   ##
========================================
  Coverage    93.08%   93.08%           
========================================
  Files           87       87           
  Lines         8125     8125           
========================================
  Hits          7563     7563           
  Misses         562      562
Files Coverage Δ
include/boost/json/detail/sse2.hpp 97.81% <100.00%> (ø)
include/boost/json/detail/utf8.hpp 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2883ff1...d79a586. Read the comment docs.

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/720/pullrequest.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://720.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/720/pullrequest.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://720.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/720/pullrequest.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://720.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/720/pullrequest.html

grisumbras and others added 5 commits March 4, 2024 11:48
@grisumbras
document dependency on Boost.Endian
b4da6e1
@grisumbras
utf-8 masks depend on endianness
a5ee70b 
Rather than reversing 32 bit numbers, when checking if the analysed code
units represent a valid utf-8 encoding, we change the constants base on
system's endianness.
@grisumbras
temp
3a3508d
@grisumbras
temp
a284d0d
@grisumbras
noinline version of is_valid_utf8
d79a586
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://720.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/720/pullrequest.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Reverse constants on big endian rather than reversing loaded data

2 participants

@grisumbras @cppalliance-bot