Skip to content

fix visibility of exceptions within Boost.Graph #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pdimov merged 1 commit into from
Sep 29, 2018
Merged

fix visibility of exceptions within Boost.Graph #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/boost/graph/bipartite.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ namespace boost {
*/

template <typename Vertex>
struct bipartite_visitor_error: std::exception
struct BOOST_SYMBOL_VISIBLE bipartite_visitor_error: std::exception
{
std::pair <Vertex, Vertex> witnesses;

Expand Down
2 changes: 1 addition & 1 deletion include/boost/graph/dimacs.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

namespace boost { namespace graph {

class dimacs_exception : public std::exception {};
class BOOST_SYMBOL_VISIBLE dimacs_exception : public std::exception {};

class dimacs_basic_reader {
public:
Expand Down
12 changes: 6 additions & 6 deletions include/boost/graph/exception.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,36 +15,36 @@

namespace boost {

struct bad_graph : public std::invalid_argument {
struct BOOST_SYMBOL_VISIBLE bad_graph : public std::invalid_argument {
bad_graph(const std::string& what_arg)
: std::invalid_argument(what_arg) { }
};

struct not_a_dag : public bad_graph {
struct BOOST_SYMBOL_VISIBLE not_a_dag : public bad_graph {
not_a_dag()
: bad_graph("The graph must be a DAG.")
{ }
};

struct negative_edge : public bad_graph {
struct BOOST_SYMBOL_VISIBLE negative_edge : public bad_graph {
negative_edge()
: bad_graph("The graph may not contain an edge with negative weight.")
{ }
};

struct negative_cycle : public bad_graph {
struct BOOST_SYMBOL_VISIBLE negative_cycle : public bad_graph {
negative_cycle()
: bad_graph("The graph may not contain negative cycles.")
{ }
};

struct not_connected : public bad_graph {
struct BOOST_SYMBOL_VISIBLE not_connected : public bad_graph {
not_connected()
: bad_graph("The graph must be connected.")
{ }
};

struct not_complete : public bad_graph {
struct BOOST_SYMBOL_VISIBLE not_complete : public bad_graph {
not_complete()
: bad_graph("The graph must be complete.")
{ }
Expand Down
2 changes: 1 addition & 1 deletion include/boost/graph/graphml.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ namespace boost
/////////////////////////////////////////////////////////////////////////////
// Graph reader exceptions
/////////////////////////////////////////////////////////////////////////////
struct parse_error: public graph_exception
struct BOOST_SYMBOL_VISIBLE parse_error: public graph_exception
{
parse_error(const std::string& err) {error = err; statement = "parse error: " + error;}
virtual ~parse_error() throw() {}
Expand Down
10 changes: 5 additions & 5 deletions include/boost/graph/graphviz.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,12 +616,12 @@ namespace boost {
/////////////////////////////////////////////////////////////////////////////
// Graph reader exceptions
/////////////////////////////////////////////////////////////////////////////
struct graph_exception : public std::exception {
struct BOOST_SYMBOL_VISIBLE graph_exception : public std::exception {
virtual ~graph_exception() throw() {}
virtual const char* what() const throw() = 0;
};

struct bad_parallel_edge : public graph_exception {
struct BOOST_SYMBOL_VISIBLE bad_parallel_edge : public graph_exception {
std::string from;
std::string to;
mutable std::string statement;
Expand All @@ -639,7 +639,7 @@ struct bad_parallel_edge : public graph_exception {
}
};

struct directed_graph_error : public graph_exception {
struct BOOST_SYMBOL_VISIBLE directed_graph_error : public graph_exception {
virtual ~directed_graph_error() throw() {}
virtual const char* what() const throw() {
return
Expand All @@ -648,7 +648,7 @@ struct directed_graph_error : public graph_exception {
}
};

struct undirected_graph_error : public graph_exception {
struct BOOST_SYMBOL_VISIBLE undirected_graph_error : public graph_exception {
virtual ~undirected_graph_error() throw() {}
virtual const char* what() const throw() {
return
Expand All @@ -657,7 +657,7 @@ struct undirected_graph_error : public graph_exception {
}
};

struct bad_graphviz_syntax: public graph_exception {
struct BOOST_SYMBOL_VISIBLE bad_graphviz_syntax: public graph_exception {
std::string errmsg;
bad_graphviz_syntax(const std::string& errmsg)
: errmsg(errmsg) {}
Expand Down
2 changes: 1 addition & 1 deletion include/boost/graph/loop_erased_random_walk.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

namespace boost {

struct loop_erased_random_walk_stuck : public std::exception {
struct BOOST_SYMBOL_VISIBLE loop_erased_random_walk_stuck : public std::exception {
virtual ~loop_erased_random_walk_stuck() throw() {}
inline virtual const char* what() const throw() {
return "Loop-erased random walk found a vertex with no out-edges";
Expand Down
4 changes: 2 additions & 2 deletions include/boost/graph/metis.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@

namespace boost { namespace graph {

class metis_exception : public std::exception {};
class metis_input_exception : public metis_exception {};
class BOOST_SYMBOL_VISIBLE metis_exception : public std::exception {};
class BOOST_SYMBOL_VISIBLE metis_input_exception : public metis_exception {};

class metis_reader
{
Expand Down