Improve Connectivity's relationship with Datasets and ImagePlus#418
Merged
Conversation
Accessing pixels in Dataset - derived ImagePlus can be really slow if the Dataset wasn't very ImagePlus like to begin with. Connectivity exposes this due to its pixel array technique of getting references to the stack slices' arrays.
Add back an ImagePlus input parameter so that clients that need to can provide an ImagePlus rather than pointlessly wrapping and unwrapping Datasets. Native ImagePlus is necessary for Connectivity's performance. It can convert a Dataset if provided with one but prefers ImagePlus if provided with both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connectivity relies on fast access to the primitive
byte[]arrays backing anImageStack. WrappedDatasetimages are slow to access.Provide a fast path for clients that can provide native
ImagePlusas a@Parameterand for those that have to provide aDatasetdo a conversion toImagePlusbacked by in-memory primitive arrays.