forked from imayushsaini/Bombsquad-Ballistica-Modded-Server
-
Notifications
You must be signed in to change notification settings - Fork 0
Update to API 8 #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vishal332008
wants to merge
127
commits into
bombsquad-community:public-server
Choose a base branch
from
imayushsaini:public-server
base: public-server
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update to API 8 #1
vishal332008
wants to merge
127
commits into
bombsquad-community:public-server
from
imayushsaini:public-server
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New firespark added! 🚒
New firespark effect!
updating aarch binary
fixed default settings and config.json
…ronPowerup.py
This pull request resolves two critical issues in `elPatronPowerup.py`:
---
🔧 Issue 1: Bomb initialization failed
- ❌ Error:
TypeError: Bomb.__init__() takes 1 positional argument but 8 were given
- 🔍 Cause:
self._pm_old_bomb(...) was passing multiple positional arguments instead of keyword arguments.
- ✅ Fix:
Replaced with keyword-based argument passing:
self._pm_old_bomb(
position=position,
velocity=velocity,
bomb_type=new_bomb_type,
blast_radius=blast_radius,
bomb_scale=bomb_scale,
source_player=source_player,
owner=owner
)
---
🎨 Issue 2: animate_array() received too many arguments
- ❌ Error:
TypeError: animate_array() takes 4 positional arguments but 5 were given
- 🔍 Cause:
An unnecessary True was passed as a fifth argument.
- ✅ Fix:
Removed the extra argument:
bs.animate_array(self.texts[type], 'color', 3, {
0: (1, 0, 0),
0.2: (1, 0.5, 0),
0.4: (1, 1, 0),
0.6: (0, 1, 0),
0.8: (0, 1, 1),
1.0: (1, 0, 1),
1.2: (1, 0, 0)
})
---
Fix: Correct Bomb init arguments and animate_array parameter in elPat…
update readme to only fetch latest changes
Updated py cmds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.