This repository was archived by the owner on Sep 2, 2021. It is now read-only.

Intial Python3 support (requires Twisted>=16)#75

Merged

bmuller merged 6 commits intobmuller:masterfrom

nocko:python3

Jun 30, 2018

Contributor

nocko commented Oct 27, 2016

Removes Spanish support from vendered BermiInflector (the file encoding is all screwed up and it was easier to do so). The right answer to that may be to submodule the upstream in a separate patchset.

Requires Twisted>=16 because thats when twisted.enterprise was ported.


          Intial Python3 support (requires Twisted>=16)

94a2c29

Contributor Author

nocko commented Oct 27, 2016

Hrm. Tox tests for all 2.7 and 3.5 environments pass on my machine. Maybe travis config needs a tweak?

nocko added 2 commits

October 27, 2016 17:18


          Fixes linter warnings from unneeded six imports

27b02bb


          Removes uneeded six-ification in a place it'd be called before deps a…

c1ad24c

…re installed

coveralls commented Oct 27, 2016 •

edited

Loading

Coverage decreased (-0.08%) to 85.787% when pulling c1ad24c on nocko:python3 into 19f4ce3 on bmuller:master.


          Fixes up Travis to test relevant twisted versions with python3

cec8bb4

coveralls commented Oct 27, 2016 •

edited

Loading

Coverage decreased (-0.08%) to 85.787% when pulling cec8bb4 on nocko:python3 into 19f4ce3 on bmuller:master.

6 similar comments

coveralls commented Oct 27, 2016

Coverage decreased (-0.08%) to 85.787% when pulling cec8bb4 on nocko:python3 into 19f4ce3 on bmuller:master.

coveralls commented Oct 27, 2016

Coverage decreased (-0.08%) to 85.787% when pulling cec8bb4 on nocko:python3 into 19f4ce3 on bmuller:master.

coveralls commented Oct 27, 2016

Coverage decreased (-0.08%) to 85.787% when pulling cec8bb4 on nocko:python3 into 19f4ce3 on bmuller:master.

coveralls commented Oct 27, 2016

Coverage decreased (-0.08%) to 85.787% when pulling cec8bb4 on nocko:python3 into 19f4ce3 on bmuller:master.

coveralls commented Oct 27, 2016 •

edited

Loading

Coverage decreased (-0.08%) to 85.787% when pulling cec8bb4 on nocko:python3 into 19f4ce3 on bmuller:master.

coveralls commented Oct 27, 2016

Coverage decreased (-0.08%) to 85.787% when pulling cec8bb4 on nocko:python3 into 19f4ce3 on bmuller:master.


          Removes superfluous list() casting when consumer supports generators

e9c528c

coveralls commented Oct 27, 2016 •

edited

Loading

Coverage decreased (-0.08%) to 85.787% when pulling e9c528c on nocko:python3 into 19f4ce3 on bmuller:master.


          Adds test to check kwarg path in logging routines

a3b2843

coveralls commented Oct 27, 2016 •

edited

Loading

Coverage increased (+0.05%) to 85.925% when pulling a3b2843 on nocko:python3 into 19f4ce3 on bmuller:master.

Owner

bmuller commented Oct 31, 2016

Thanks @nocko for the code update! I'm going to try to get #74 merged in, and then this one, for a new major release.

mracter commented Jun 25, 2018

Any updates on the status of this feature? Would very much like to use this for a Python3 project, as Python2.7 is no longer supported.

Owner

bmuller commented Jun 30, 2018

Sorry for the delay on this, @mracter! I'm going to go ahead and merge now while waiting on #74. I'll make a new major release, too.

PS: My old code looks so gross.

Owner

bmuller commented Jun 30, 2018

And thanks @nocko!

bmuller merged commit 0e82b88 into bmuller:master

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet