Adding BioXAS beamline Simulation - #333
Draft
jessica-moylan wants to merge 7 commits into
Draft
Conversation
jessica-moylan
requested review from
MTakahashi-KWH and
thopkins32
and removed request for
MTakahashi-KWH
July 29, 2026 12:36
thopkins32
marked this pull request as draft
July 29, 2026 13:44
thopkins32
reviewed
Jul 29, 2026
thopkins32
left a comment
thopkins32
left a comment
Collaborator
There was a problem hiding this comment.
Discussed elsewhere. Almost good to merge, just missing a few things:
- Explanation of the problem setup (DOF choice, objective choice, expected optimal values)
- Removal of
"auto"on XRT model - Trying with
method="quality"to see if it converges faster than Ax defaults
jessica-moylan
marked this pull request as ready for review
July 29, 2026 18:18
jessica-moylan
marked this pull request as draft
July 30, 2026 15:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new tutorial, based off an XRT simulation of the BioXAS bemaline at the Canadian Light Source that emphasizes blop's ability to mange more complex optimization problems that use >2 degrees of freedom, this tutorial uses 6, as well as having the optimization problem being a multi-objective one.