starter pack metrics #9116
Open
starter pack metrics #9116
+20
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mozzius
requested changes
Oct 1, 2025
src/logger/metrics.ts
Outdated
Comment on lines
324
to
325
| 'starterPack:addUser': {} | ||
| 'starterPack:removeUser': {} |
There was a problem hiding this comment.
All these other ones include the starterPark uri, I think add that here too for consistency. You can make it optional, in case the starter pack doesn't exist yet
There was a problem hiding this comment.
Alex said these are events emitted during the creation flow of a new starter pack which means there will never be any starterpack uri. Do we want to emit this when adding/removing user to existing starter pack too?
mozzius
approved these changes
Oct 2, 2025
src/logger/metrics.ts
Outdated
| starterPackUri?: string | ||
| } | ||
| 'starterPack:removeUser': { | ||
| starterPackUri?: string |
There was a problem hiding this comment.
nit
Suggested change
| starterPackUri?: string | |
| starterPack?: string |
src/logger/metrics.ts
Outdated
| 'starterPack:addUser': {} | ||
| 'starterPack:removeUser': {} | ||
| 'starterPack:addUser': { | ||
| starterPackUri?: string |
There was a problem hiding this comment.
nit
Suggested change
| starterPackUri?: string | |
| starterPack?: string |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new starter pack related event metrics:
https://linear.app/blueskyweb/issue/APP-1425/metrics-event-add-to-starter-pack