Language selection and suggestion UX improvements #9067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iting post (#8886) * feat: don't retain accepted language suggestion after finishing or exiting post * fix: rebase fixes * fix: rebase fixes * chore: lint
|
surfdude29
reviewed
Sep 23, 2025
Co-authored-by: surfdude29 <[email protected]>
elijaharita
reviewed
Sep 24, 2025
…ge-selection * origin/main: (29 commits) add patent pledge link to readme (#9118) Fix feedfeedback metrics not distinguishing which feed it's from (#9099) Nightly source-language update Add StackedButton component (#9086) [Web] Fix thread jumps (#9111) Button tweaks (#9106) Update admonition component (#9068) fix gap on profile (#9081) Nightly source-language update Catch errors on geolocation request, reduce Sentry logs (#9098) remove root sibling library (#9097) don't send some "activity no longer available" errors (#9100) Log OTA errors properly (#9101) Fix link crash (#9102) Send inferrable interactions to third-party feeds (#9094) patch react native screens (#9087) fix: remove escapejs and fix profile issues feat: profile.html escapejs feat: post.html structured content, wip feat: profile.html structured content ...
arcalinea
temporarily deployed
to
eric/temporary-language-selection - social-app PR #9067
Render
Destroyed
mozzius
approved these changes
Oct 2, 2025
NekoDrone
added a commit
to NekoDrone/catsky-social
that referenced
this pull request
Oct 3, 2025
* Send inferrable interactions to third-party feeds (bluesky-social#9094) * Fix link crash (bluesky-social#9102) * fix link crash * fix link crash * Log OTA errors properly (bluesky-social#9101) * Log OTA errors properly * filter out network errors * don't send some "activity no longer available" errors (bluesky-social#9100) * remove root sibling library (bluesky-social#9097) * Catch errors on geolocation request, reduce Sentry logs (bluesky-social#9098) * Nightly source-language update * fix gap on profile (bluesky-social#9081) * Update admonition component (bluesky-social#9068) * update admonition component * fix linting, adominition alighment * design tweak * edge cases for admonition, update storybook * Update src/components/Admonition.tsx Co-authored-by: Samuel Newman <[email protected]> * fix mobile version * change button style --------- Co-authored-by: Samuel Newman <[email protected]> * Button tweaks (bluesky-social#9106) * Tweak button colors * Semi bold only for tiny buttons * [Web] Fix thread jumps (bluesky-social#9111) * [Web] Fix thread jumps * Comment formatting --------- Co-authored-by: Eric Bailey <[email protected]> * Add StackedButton component (bluesky-social#9086) * Nightly source-language update * Fix feedfeedback metrics not distinguishing which feed it's from (bluesky-social#9099) * fix feedfeedback metrics being sent for all feeds * remove `discover:` metrics * add patent pledge link to readme (bluesky-social#9118) * Language selection and suggestion UX improvements (bluesky-social#9067) * feat: don't retain accepted language suggestion after finishing or exiting post (bluesky-social#8886) * feat: don't retain accepted language suggestion after finishing or exiting post * fix: rebase fixes * fix: rebase fixes * chore: lint * Rename onChange for clarity * Improve logic in composer * Handle user override more explicitly * Drill in onSelectLanguage callback into dialog too * Fix typo Co-authored-by: surfdude29 <[email protected]> * Make text crystal clear * Handle multiple languages --------- Co-authored-by: Elijah Seed-Arita <[email protected]> Co-authored-by: surfdude29 <[email protected]> * Tighten up eslint rule to catch unused `const {_} = useLingui()` (bluesky-social#9122) * tighten eslint config to catch unused `useLingui`s * fix now-invalid uses of _ * remove unused function that produces a ton of eslint warnings * upgrade react compiler plugin * [Fix Logouts] Remove buggy hackfix (bluesky-social#9108) * Rip out the network hack in favor of bluesky-social/atproto#4238 * Bump api pkg * Debug code * Revert "Debug code" This reverts commit 38445f3. --------- Co-authored-by: Eric Bailey <[email protected]> * Nightly source-language update * fix: missed alf reversion --------- Co-authored-by: dan <[email protected]> Co-authored-by: Samuel Newman <[email protected]> Co-authored-by: pfrazee <[email protected]> Co-authored-by: Chenyu <[email protected]> Co-authored-by: Eric Bailey <[email protected]> Co-authored-by: Daniel Holmgren <[email protected]> Co-authored-by: Elijah Seed-Arita <[email protected]> Co-authored-by: surfdude29 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on the excellent work in #8886. This PR does a few additional things:
Post marked as
italian,spanish:Replying in
spanish: