Migrate to @bsky.app/alf package
#9030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@github-actions ota |
|
Your requested OTA deployment was successful! You may now apply it by either scanning the QR code or opening the deep link below in your browser:
|
mozzius
reviewed
Sep 23, 2025
mozzius
reviewed
Sep 23, 2025
This reverts commit 7a86195.
estrattonbailey
force-pushed
the
alf-pkg
branch
from
83c7c58 to
549bd40
Compare
arcalinea
temporarily deployed
to
alf-pkg - social-app PR #9030
Render
Destroyed
mozzius
reviewed
Sep 24, 2025
Comment on lines
+10
to
+14
| '-2': 1 - factor * 1, // unused | ||
| '-1': 1 - factor * 1, | ||
| '0': 1, // default | ||
| '1': 1 + factor * 1, | ||
| '2': 1 + factor * 1, // unused |
There was a problem hiding this comment.
any reason we even have the -2 and 2?
There was a problem hiding this comment.
Nah just leftovers, just didn't clean up here
mozzius
reviewed
Sep 24, 2025
Comment on lines
5
to
+7
| export const color = { | ||
| temp_purple: 'rgb(105 0 255)', | ||
| temp_purple_dark: 'rgb(83 0 202)', | ||
| } as const | ||
|
|
||
| export const space = { | ||
| _2xs: 2, | ||
| xs: 4, | ||
| sm: 8, | ||
| md: 12, | ||
| lg: 16, | ||
| xl: 20, | ||
| _2xl: 24, | ||
| _3xl: 28, | ||
| _4xl: 32, | ||
| _5xl: 40, | ||
| } as const | ||
|
|
||
| export const fontSize = { | ||
| _2xs: 10, | ||
| xs: 12, | ||
| sm: 14, | ||
| md: 16, | ||
| lg: 18, | ||
| xl: 20, | ||
| _2xl: 22, | ||
| _3xl: 26, | ||
| _4xl: 32, | ||
| _5xl: 40, | ||
| } as const | ||
|
|
||
| export const lineHeight = { | ||
| none: 1, | ||
| normal: 1.5, | ||
| relaxed: 1.625, | ||
| } as const | ||
|
|
||
| export const borderRadius = { | ||
| _2xs: 2, | ||
| xs: 4, | ||
| sm: 8, | ||
| md: 12, | ||
| lg: 16, | ||
| full: 999, | ||
| } as const | ||
|
|
||
| /** | ||
| * These correspond to Inter font files we actually load. | ||
| */ | ||
| export const fontWeight = { | ||
| normal: '400', | ||
| medium: '500', | ||
| bold: '600', | ||
| heavy: '800', | ||
| temp_purple: tokens.labelerColor.purple, | ||
| temp_purple_dark: tokens.labelerColor.purple_dark, |
There was a problem hiding this comment.
ah we should add Adminition orange to here
There was a problem hiding this comment.
Oh yeah that's a good idea too
mozzius
approved these changes
Sep 24, 2025
NekoDrone
added a commit
to NekoDrone/catsky-social
that referenced
this pull request
Sep 27, 2025
This reverts commit bd17f04.
APiligrim
pushed a commit
to internet-development/bluesky-social-app
that referenced
this pull request
Oct 4, 2025
* Add storybook shortcut in dev * Migrate to alg pkg * Migrate font_bold to new font_semi_bold * Migrate font_heavy to font_bold * Fix old theme refs * Remove leading util * Bump * Revert "Add storybook shortcut in dev" This reverts commit 7a86195. * Remove alf script * Adjust font scale * Bump * Bump pkg * Migrate values from conflicts * Create default themes outside react * Use built-in alf utils * Migrate old font styles * Remove unused tokens * Move theme creation to more appropriate file * Update button colors * Adjust TextField colors, line heights
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR
@bsky.app/alfacts as the "core" library. That library is intended to be agnostic of JS runtime, and contain only the building blocks needed for more use-case-specific integrations.In that library, a few changes where made, notably:
font_boldpreviously to refer to the "semi bold" weight, we now usefont_semi_boldOther than that, this PR basically contains some refreshed colors. There should be no noticeable changes to font sizes/weights or other tokens.