[APP-1403] Profile empty states #8969
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APiligrim
changed the title
APiligrim
force-pushed
the
@APiligrim/update-empty-states
branch
from
7b40797 to
b7b95c5
Compare
mozzius
reviewed
Sep 5, 2025
mozzius
reviewed
Sep 5, 2025
mozzius
requested changes
Sep 5, 2025
APiligrim
force-pushed
the
@APiligrim/update-empty-states
branch
from
b009b80 to
3f28311
Compare
APiligrim
force-pushed
the
@APiligrim/update-empty-states
branch
from
3f28311 to
c26f41a
Compare
APiligrim
force-pushed
the
@APiligrim/update-empty-states
branch
2 times, most recently
from
e18f12d to
f5a9c14
Compare
APiligrim
force-pushed
the
@APiligrim/update-empty-states
branch
from
144a28e to
e6e4aff
Compare
mozzius
requested changes
Sep 25, 2025
There was a problem hiding this comment.
Okay, it's looking pretty nice! I think my one piece of feedback is about the API of the EmptyState component - the icon prop should look more like this:
<EmptyState
icon={ExampleIcon}
// etc
/>That way, we can just slot in icons much more easily and not have to think about styles or sizes or colors.
APiligrim
force-pushed
the
@APiligrim/update-empty-states
branch
from
03f7d05 to
af283f0
Compare
APiligrim
force-pushed
the
@APiligrim/update-empty-states
branch
from
af283f0 to
dc94747
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the current
<EmptyState/>component to match the latest design and updates the screens with the corresponding copy and icon for theFeedfrom the new design. TicketDesign:
Web Previews:
Screen.Recording.2025-09-10.at.10.59.07.AM.mov
Mobile Previews:
https://github.com/user-attachments/assets/781741a4-a824-4210-aee5-b7a42e0c3550
Screen.Recording.2025-09-03.at.8.29.08.PM.mov
Screen.Recording.2025-09-17.at.11.23.45.AM.mov
Screen.Recording.2025-09-17.at.11.22.19.AM.mov